From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 16 Jan 2024 22:16:40 +0000 (+0100)
Subject: dbus-unit: don't eat up error codes needlessly
X-Git-Tag: v256-rc1~1126^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4212636763af87102aee6dc2d57aa6cb613991a4;p=thirdparty%2Fsystemd.git

dbus-unit: don't eat up error codes needlessly
---

diff --git a/src/core/dbus-unit.c b/src/core/dbus-unit.c
index 3aeb85e4524..7aa44b2393e 100644
--- a/src/core/dbus-unit.c
+++ b/src/core/dbus-unit.c
@@ -2271,7 +2271,9 @@ static int bus_unit_set_transient_property(
                                 u->documentation = strv_free(u->documentation);
                                 unit_write_settingf(u, flags, name, "%s=", name);
                         } else {
-                                strv_extend_strv(&u->documentation, l, false);
+                                r = strv_extend_strv(&u->documentation, l, /* filter_duplicates= */ false);
+                                if (r < 0)
+                                        return r;
 
                                 STRV_FOREACH(p, l)
                                         unit_write_settingf(u, flags, name, "%s=%s", name, *p);