From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sat, 1 Jul 2017 08:11:16 +0000 (+1200)
Subject: Fix message packing error handling in mgr and snmp SMP Forwarders.
X-Git-Tag: SQUID_3_5_28~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42151e910f3af16391dabb49a633ccab05ef5029;p=thirdparty%2Fsquid.git

Fix message packing error handling in mgr and snmp SMP Forwarders.

A missing "return" resulted in Forwarders sending garbage (or worse) to
Coordinator.
---

diff --git a/src/ipc/Forwarder.cc b/src/ipc/Forwarder.cc
index 13e051fff3..58a72915fa 100644
--- a/src/ipc/Forwarder.cc
+++ b/src/ipc/Forwarder.cc
@@ -62,6 +62,7 @@ Ipc::Forwarder::start()
         // assume the pack() call failed because the message did not fit
         // TODO: add a more specific exception?
         handleError();
+        return;
     }
 
     SendMessage(Ipc::Port::CoordinatorAddr(), message);