From: Kamalesh Babulal Date: Wed, 20 Jul 2022 17:15:27 +0000 (-0600) Subject: api.c: fix string termination in cgroup_get_procname_from_procfs() X-Git-Tag: v3.0~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=422c0300583a7b450838e4936ba0d51584354831;p=thirdparty%2Flibcgroup.git api.c: fix string termination in cgroup_get_procname_from_procfs() Fix non-terminated string warning, reported by Coverity tool: CID 258273 (#2 of 2): String not null terminated (STRING_NULL)6. string_null: Passing unterminated string buf to strdup, which expects a null-terminated string. use snprintf() instead of sprintf(), to string terminate cgroup_get_procname_from_procfs(). Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- diff --git a/src/api.c b/src/api.c index fa4a3eda..c38c2b5f 100644 --- a/src/api.c +++ b/src/api.c @@ -5370,7 +5370,7 @@ int cgroup_get_procname_from_procfs(pid_t pid, char **procname) /* Get the full patch of process name from /proc//exe. */ memset(buf, '\0', sizeof(buf)); - sprintf(path, "/proc/%d/exe", pid); + snprintf(path, FILENAME_MAX, "/proc/%d/exe", pid); if (readlink(path, buf, sizeof(buf)) < 0) { /* * readlink() fails if a kernel thread, and a process name