From: Shravan Rangarajuvenkata (shrarang) <shrarang@cisco.com>
Date: Fri, 26 Feb 2021 20:02:45 +0000 (+0000)
Subject: Merge pull request #2768 in SNORT/snort3 from ~SHRARANG/snort3:appid_cppcheck to... 
X-Git-Tag: 3.1.2.0~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4235a0438f05de360ca6caed65ee367f5976d762;p=thirdparty%2Fsnort3.git

Merge pull request #2768 in SNORT/snort3 from ~SHRARANG/snort3:appid_cppcheck to master

Squashed commit of the following:

commit 540aa99530d3d7e9ff6282691891553fcb9153da
Author: Shravan Rangaraju <shrarang@cisco.com>
Date:   Fri Feb 26 12:41:42 2021 -0500

    appid: fixes for cppcheck warnings
---

diff --git a/src/network_inspectors/appid/test/appid_discovery_test.cc b/src/network_inspectors/appid/test/appid_discovery_test.cc
index d23faa2d6..6504b51a6 100644
--- a/src/network_inspectors/appid/test/appid_discovery_test.cc
+++ b/src/network_inspectors/appid/test/appid_discovery_test.cc
@@ -275,11 +275,6 @@ TPLibHandler* TPLibHandler::self = nullptr;
 THREAD_LOCAL AppIdStats appid_stats;
 THREAD_LOCAL AppIdDebug* appidDebug = nullptr;
 void AppIdDebug::activate(const Flow*, const AppIdSession*, bool) { active = false; }
-void check_session_for_AF_indicator(Packet*, AppidSessionDirection, AppId, const OdpContext&) {}
-AppId check_session_for_AF_forecast(AppIdSession&, Packet*, AppidSessionDirection, AppId)
-{
-    return APP_ID_UNKNOWN;
-}
 
 bool AppIdReloadTuner::tinit() { return false; }