From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 23 Feb 2024 08:01:52 +0000 (+0000)
Subject: Fix misleading Dns::CachedIps::restoreGoodness() debugging (#1692)
X-Git-Tag: SQUID_6_8~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42403ecff90b770a7d13ff0a5cbf2a94534e069e;p=thirdparty%2Fsquid.git

Fix misleading Dns::CachedIps::restoreGoodness() debugging (#1692)
---

diff --git a/src/ipcache.cc b/src/ipcache.cc
index 0907364b8d..e5aec7f20d 100644
--- a/src/ipcache.cc
+++ b/src/ipcache.cc
@@ -974,9 +974,10 @@ Dns::CachedIps::restoreGoodness(const char *name)
         for (auto &cachedIp: ips)
             cachedIp.forgetMarking();
         badCount_ = 0;
+        debugs(14, 3, "cleared all " << size() << " bad IPs for " << name);
+        // fall through to reset goodPosition and report the current state
     }
     Must(seekNewGood(name));
-    debugs(14, 3, "cleared all IPs for " << name << "; now back to " << *this);
 }
 
 bool