From: Dylan William Hardison <dylan@hardison.net>
Date: Thu, 23 Oct 2014 16:31:25 +0000 (-0400)
Subject: Bug 1083258 - The size check for input <select>s on show_bug.cgi doesn't take into... 
X-Git-Tag: release-5.1.1~485
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=424bbc87bd2c105c4c5c6aab6c3f101606a400ec;p=thirdparty%2Fbugzilla.git

Bug 1083258 - The size check for input <select>s on show_bug.cgi doesn't take into account is_active
r=dkl a=glob
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index aa5085fe70..aec7c1e82d 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3951,6 +3951,11 @@ sub choices {
     my @resolutions = grep($_->name, @{ $resolution_field->legal_values });
     $choices{'resolution'} = \@resolutions;
 
+    foreach my $key (keys %choices) {
+        my $value = $self->$key;
+        $choices{$key} = [grep { $_->is_active || $_->name eq $value } @{ $choices{$key} }];
+    }
+
     $self->{'choices'} = \%choices;
     return $self->{'choices'};
 }
diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl
index ca0e771e06..a7674faf85 100644
--- a/template/en/default/bug/edit.html.tmpl
+++ b/template/en/default/bug/edit.html.tmpl
@@ -1194,7 +1194,6 @@
       <input type="hidden" id="[% selname %]_dirty">
       <select id="[% selname %]" name="[% selname %]">
         [% FOREACH x = bug.choices.${selname} %]
-          [% NEXT IF NOT x.is_active AND x.name != bug.${selname} %]
           <option value="[% x.name FILTER html %]"
             [% " selected" IF x.name == bug.${selname} %]>
             [%- x.name FILTER html %]