From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Fri, 15 Jun 2018 09:29:52 +0000 (+0200)
Subject: coverity: #1425764
X-Git-Tag: lxc-3.1.0~245^2~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4250ef64b3ce38e437ad8f83db0383010014339c;p=thirdparty%2Flxc.git

coverity: #1425764

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index de4a49e62..b974deb9b 100644
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -1561,15 +1561,24 @@ static bool create_run_template(struct lxc_container *c, char *tpath,
 
 			/* note n2[n2args-1] is NULL */
 			n2[n2args - 5] = "--mapped-uid";
-			snprintf(txtuid, 20, "%d", hostuid_mapped);
+
+			ret = snprintf(txtuid, 20, "%d", hostuid_mapped);
+			if (ret < 0 || ret >= 20) {
+				free(newargv);
+				free(n2);
+				_exit(EXIT_FAILURE);
+			}
+
 			n2[n2args - 4] = txtuid;
 			n2[n2args - 3] = "--mapped-gid";
+
 			ret = snprintf(txtgid, 20, "%d", hostgid_mapped);
 			if (ret < 0 || ret >= 20) {
 				free(newargv);
 				free(n2);
 				_exit(EXIT_FAILURE);
 			}
+
 			n2[n2args - 2] = txtgid;
 			n2[n2args - 1] = NULL;
 			free(newargv);