From: Francis Dupont <fdupont@isc.org>
Date: Fri, 7 Dec 2018 21:15:34 +0000 (+0100)
Subject: [283-perfdhcp-indicated-requests-rate-is-not-kept-during-testing] Minimal fixes to... 
X-Git-Tag: 421-create-config-backend-for-dhcpv6-base_base~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4254960b014c2335ab5d3834bb57a9b3984423ce;p=thirdparty%2Fkea.git

[283-perfdhcp-indicated-requests-rate-is-not-kept-during-testing] Minimal fixes to make it to build on macOS
---

diff --git a/src/bin/perfdhcp/receiver.cc b/src/bin/perfdhcp/receiver.cc
index e26e06024e..dce28f1dd4 100644
--- a/src/bin/perfdhcp/receiver.cc
+++ b/src/bin/perfdhcp/receiver.cc
@@ -21,7 +21,7 @@ Receiver::start() {
         return;
     }
     assert(run_flag_.test_and_set() == false);
-    recv_thread_ = move(unique_ptr<thread>(new thread{&Receiver::run, this}));
+    recv_thread_.reset(new thread{&Receiver::run, this});
 }
 
 void
diff --git a/src/bin/perfdhcp/receiver.h b/src/bin/perfdhcp/receiver.h
index 9fe652fe1a..ce7fc4b114 100644
--- a/src/bin/perfdhcp/receiver.h
+++ b/src/bin/perfdhcp/receiver.h
@@ -37,9 +37,11 @@ typedef boost::shared_ptr<Pkt> PktPtr;
 /// in main thread packets can be consumed from the queue using getPkt
 /// method.
 class Receiver {
+public:
     /// \brief Socket for receiving.
     const BetterSocket& socket_;
 
+private:
     /// \brief Flag indicating if thread should run (true) or not (false).
     boost::atomic_flag run_flag_;
 
diff --git a/src/bin/perfdhcp/test_control.cc b/src/bin/perfdhcp/test_control.cc
index 066955fb67..d890edae5b 100644
--- a/src/bin/perfdhcp/test_control.cc
+++ b/src/bin/perfdhcp/test_control.cc
@@ -1238,7 +1238,7 @@ TestControl::processReceivedPacket6(const BetterSocket& socket,
 void
 TestControl::consumeReceivedPackets(Receiver& receiver, const BetterSocket& socket) {
     PktPtr pkt;
-    while (pkt = receiver.getPkt()) {
+    while ((pkt = receiver.getPkt())) {
         if (CommandOptions::instance().getIpVersion() == 4) {
             Pkt4Ptr pkt4 = boost::dynamic_pointer_cast<Pkt4>(pkt);
             processReceivedPacket4(socket, pkt4);