From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 28 Nov 2019 13:58:55 +0000 (+0100)
Subject: qemu: Check for explicit failure of qemuBlockSnapshotAddBlockdev
X-Git-Tag: v6.0.0-rc1~321
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4258eba6ed3adf1a8f7c4126cf18575527255fab;p=thirdparty%2Flibvirt.git

qemu: Check for explicit failure of qemuBlockSnapshotAddBlockdev

Check that the value is less than 0.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e65150f42b..0a4a2471c7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -15592,7 +15592,7 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
         if (blockdev) {
             if (qemuBlockSnapshotAddBlockdev(actions,
                                              diskdata[i].disk,
-                                             diskdata[i].src))
+                                             diskdata[i].src) < 0)
                 goto cleanup;
         } else {
             if (qemuBlockSnapshotAddLegacy(actions,