From: Jonathan Ellis <jbellis@gmail.com>
Date: Fri, 3 Aug 2007 04:49:34 +0000 (+0000)
Subject: add comment, intermediate var for readability
X-Git-Tag: rel_0_4beta1~100
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42812c06c182b236f491cb33315527a54fcba002;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

add comment, intermediate var for readability
---

diff --git a/lib/sqlalchemy/topological.py b/lib/sqlalchemy/topological.py
index 56c8cb46e4..dcfe9ea715 100644
--- a/lib/sqlalchemy/topological.py
+++ b/lib/sqlalchemy/topological.py
@@ -307,9 +307,9 @@ class QueueDependencySorter(object):
         for parent in edges.get_parents():
             traverse(parent)
 
-        for cycle in dict([(id(s), s) for s in cycles.values()]).values():
-            edgecollection = []
-            for edge in edges:
-                if edge[0] in cycle and edge[1] in cycle:
-                    edgecollection.append(edge)
+        # sets are not hashable, so uniquify with id
+        unique_cycles = dict([(id(s), s) for s in cycles.values()]).values()
+        for cycle in unique_cycles:
+            edgecollection = [edge for edge in edges
+                              if edge[0] in cycle and edge[1] in cycle]
             yield edgecollection