From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Sat, 30 Dec 2023 15:43:29 +0000 (-0800)
Subject: Fix: setting empty doc link with docs to be removed (#5174)
X-Git-Tag: v2.3.0~1^2~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=428ffb4729138d0937987314b8ef6324078b3577;p=thirdparty%2Fpaperless-ngx.git

Fix: setting empty doc link with docs to be removed (#5174)
---

diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py
index c07b00f78f..5e80379600 100644
--- a/src/documents/serialisers.py
+++ b/src/documents/serialisers.py
@@ -527,6 +527,10 @@ class CustomFieldInstanceSerializer(serializers.ModelSerializer):
         """
         Add or remove 'symmetrical' links to `document` on all `target_doc_ids`
         """
+
+        if target_doc_ids is None:
+            target_doc_ids = []
+
         # Check if any documents are going to be removed from the current list of links and remove the symmetrical links
         current_field_instance = CustomFieldInstance.objects.filter(
             field=field,
@@ -540,9 +544,6 @@ class CustomFieldInstanceSerializer(serializers.ModelSerializer):
                 if doc_id not in target_doc_ids:
                     self.remove_doclink(document, field, doc_id)
 
-        if target_doc_ids is None:
-            target_doc_ids = []
-
         # Create an instance if target doc doesnt have this field or append it to an existing one
         existing_custom_field_instances = {
             custom_field.document_id: custom_field