From: Chen Ni Date: Thu, 15 Jan 2026 02:38:00 +0000 (+0800) Subject: usb: dwc3: google: Remove redundant dev_err() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4298475deecbd12f7d5a83b340f59ae644c37a5e;p=thirdparty%2Flinux.git usb: dwc3: google: Remove redundant dev_err() The platform_get_irq_byname() function already prints an error message internally upon failure using dev_err_probe(). Therefore, the explicit dev_err() is redundant and results in duplicate error logs. Remove the redundant dev_err() call to clean up the error path. Signed-off-by: Chen Ni Acked-by: Thinh Nguyen Link: https://patch.msgid.link/20260115023800.4142416-1-nichen@iscas.ac.cn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c index a19857bd6b13..2105c72af753 100644 --- a/drivers/usb/dwc3/dwc3-google.c +++ b/drivers/usb/dwc3/dwc3-google.c @@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d int irq; irq = platform_get_irq_byname(pdev, irq_name); - if (irq < 0) { - dev_err(google->dev, "invalid irq name %s\n", irq_name); + if (irq < 0) return irq; - } irq_set_status_flags(irq, IRQ_NOAUTOEN); ret = devm_request_threaded_irq(google->dev, irq, NULL,