From: James Jones <jejones3141@gmail.com>
Date: Wed, 3 Aug 2022 13:43:58 +0000 (-0500)
Subject: Annotate false positive in fr_dict_attr_verify() (CID #1504052) (#4642)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=429d842dfe70d631b0626bd501d94d0b2ed1e91f;p=thirdparty%2Ffreeradius-server.git

Annotate false positive in fr_dict_attr_verify() (CID #1504052) (#4642)

The preceding fr_assert_msg() should keep attributes without
namespaces from reaching the dict_attr_namespace() call, so it
should never return NULL... but coverity doesn't know that.
---

diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index f6a8b46e388..701036b9e62 100644
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -4172,6 +4172,7 @@ void fr_dict_attr_verify(char const *file, int line, fr_dict_attr_t const *da)
 		/*
 		 *	Check the namespace hash table is ok
 		 */
+		/* coverity[dereference] */
 		fr_hash_table_verify(dict_attr_namespace(da));
 	}
 		break;