From: George Joseph <gjoseph@sangoma.com>
Date: Fri, 3 Jan 2025 21:02:22 +0000 (-0700)
Subject: gcc14: Fix issues caught by gcc 14
X-Git-Tag: 21.7.0-rc1~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42ae9c9e986e2d622bf1ea3c5d8a04bb12e6ce84;p=thirdparty%2Fasterisk.git

gcc14: Fix issues caught by gcc 14

* test_message.c: Fix segfaults caused by passing NULL as an sprintf fmt.

(cherry picked from commit 1fbd42936e28631fe182abe6dca584b73c3b018d)
---

diff --git a/tests/test_message.c b/tests/test_message.c
index dff6bd37b4..a8253ba23a 100644
--- a/tests/test_message.c
+++ b/tests/test_message.c
@@ -680,10 +680,10 @@ AST_TEST_DEFINE(test_message_has_destination_dialplan)
 	ast_msg_set_exten(msg, "__I_SHOULD_NOT_EXIST_PLZ__");
 	ast_test_validate(test, ast_msg_has_destination(msg) == 0);
 
-	ast_msg_set_exten(msg, NULL);
+	ast_msg_set_exten(msg, "%s", "");
 	ast_test_validate(test, ast_msg_has_destination(msg) == 0);
 
-	ast_msg_set_context(msg, NULL);
+	ast_msg_set_context(msg, "%s", "");
 	ast_msg_set_exten(msg, TEST_EXTENSION);
 	ast_test_validate(test, ast_msg_has_destination(msg) == 0);
 
@@ -716,10 +716,10 @@ AST_TEST_DEFINE(test_message_has_destination_handler)
 
 	ast_msg_set_to(msg, "foo");
 	ast_msg_set_context(msg, TEST_CONTEXT);
-	ast_msg_set_exten(msg, NULL);
+	ast_msg_set_exten(msg, "%s", "");
 	ast_test_validate(test, ast_msg_has_destination(msg) == 1);
 
-	ast_msg_set_context(msg, NULL);
+	ast_msg_set_context(msg, "%s", "");
 	ast_test_validate(test, ast_msg_has_destination(msg) == 1);
 
 	ast_msg_set_to(msg, "__I_SHOULD_NOT_EXIST_PLZ__");
@@ -756,7 +756,7 @@ AST_TEST_DEFINE(test_message_msg_send)
 
 	ast_msg_set_to(msg, "foo");
 	ast_msg_set_context(msg, TEST_CONTEXT);
-	ast_msg_set_exten(msg, NULL);
+	ast_msg_set_exten(msg, "%s", "");
 	ast_test_validate(test, ast_msg_has_destination(msg) == 1);
 
 	if (!ast_msg_send(msg, "testmsg:foo", "blah")) {