From: Andrei Pavel <andrei@isc.org>
Date: Mon, 20 May 2024 20:28:02 +0000 (+0300)
Subject: [#3256] address review
X-Git-Tag: Kea-2.6.0~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42bd2b586707aaa59d4041845e85a6183d825e52;p=thirdparty%2Fkea.git

[#3256] address review
---

diff --git a/src/lib/cc/data.cc b/src/lib/cc/data.cc
index b7bc6c399a..f48bed5e81 100644
--- a/src/lib/cc/data.cc
+++ b/src/lib/cc/data.cc
@@ -902,7 +902,7 @@ StringElement::toJSON(std::ostream& ss) const {
             ss << '\\' << 't';
             break;
         default:
-            if (((c >= 0) && (c < 0x20)) || (c < 0) || (c >= 0x7f)) {
+            if (c < 0x20 || c == 0x7f) {
                 std::ostringstream esc;
                 esc << "\\u"
                     << hex
diff --git a/src/lib/http/http_message_parser_base.cc b/src/lib/http/http_message_parser_base.cc
index cbda31a013..284e847b76 100644
--- a/src/lib/http/http_message_parser_base.cc
+++ b/src/lib/http/http_message_parser_base.cc
@@ -262,7 +262,6 @@ HttpMessageParserBase::popNextFromBuffer(std::string& next, const size_t limit)
 
 bool
 HttpMessageParserBase::isChar(const signed char c) const {
-    // was (c >= 0) && (c <= 127)
     return (c >= 0);
 }