From: Jason R. Coombs Date: Wed, 20 Jun 2012 14:24:24 +0000 (-0400) Subject: Prefer assertEqual to simply assert per recommendation in issue6727. X-Git-Tag: v3.3.0b1~181 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42c9b04278205ce0a7d3a91a552d60d7d1eb6d86;p=thirdparty%2FPython%2Fcpython.git Prefer assertEqual to simply assert per recommendation in issue6727. Clarified comment on disabled code to reference issue15093. --- diff --git a/Lib/test/test_import.py b/Lib/test/test_import.py index 7ae690bbdeb1..c94d7bd553cd 100644 --- a/Lib/test/test_import.py +++ b/Lib/test/test_import.py @@ -707,14 +707,19 @@ class TestSymbolicallyLinkedPackage(unittest.TestCase): os.mkdir(self.tagged) init_file = os.path.join(self.tagged, '__init__.py') open(init_file, 'w').close() - assert os.path.exists(init_file) + self.assertEqual(os.path.exists(init_file), True) # now create a symlink to the tagged package # sample -> sample-tagged os.symlink(self.tagged, self.package_name) - # assert os.path.isdir(self.package_name) # currently fails - assert os.path.isfile(os.path.join(self.package_name, '__init__.py')) + # disabled because os.isdir currently fails (see issue 15093) + # self.assertEqual(os.path.isdir(self.package_name), True) + + self.assertEqual( + os.path.isfile(os.path.join(self.package_name, '__init__.py')), + True, + ) @property def tagged(self):