From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 15 May 2018 10:33:22 +0000 (+0200)
Subject: coverity: #1435604
X-Git-Tag: lxc-3.1.0~304^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42cc40833c6a0e3ac01006c4ed35fb73ea958a93;p=thirdparty%2Flxc.git

coverity: #1435604

Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/network.c b/src/lxc/network.c
index a7e05280d..c77f8c7ce 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -1916,8 +1916,10 @@ int lxc_bridge_attach(const char *bridge, const char *ifname)
 		return -errno;
 
 	retlen = strlcpy(ifr.ifr_name, bridge, IFNAMSIZ);
-	if (retlen >= IFNAMSIZ)
+	if (retlen >= IFNAMSIZ) {
+		close(fd);
 		return -E2BIG;
+	}
 
 	ifr.ifr_name[IFNAMSIZ - 1] = '\0';
 	ifr.ifr_ifindex = index;