From: Witold Kręcicki <wpk@isc.org>
Date: Fri, 17 Jan 2020 11:07:34 +0000 (+0100)
Subject: calling isc__nm_udp_send() on a non-udp socket is not 'unexpected', it's a critical... 
X-Git-Tag: v9.16.0~60^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42f0e25a4c40b231c04d0493ebbc21105d1617c7;p=thirdparty%2Fbind9.git

calling isc__nm_udp_send() on a non-udp socket is not 'unexpected', it's a critical failure
---

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index cb14425703c..d4f27a7c36a 100644
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -383,7 +383,8 @@ isc__nm_udp_send(isc_nmhandle_t *handle, isc_region_t *region,
 	} else if (sock->type == isc_nm_udplistener) {
 		psock = sock;
 	} else {
-		return (ISC_R_UNEXPECTED);
+		INSIST(0);
+		ISC_UNREACHABLE();
 	}
 
 	if (!isc__nmsocket_active(sock)) {