From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 26 May 2017 02:02:46 +0000 (-0400)
Subject: CID 1409874: Always call va_end
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=430cd245ea0a9ed70f48c1cc97f1415049399b8a;p=thirdparty%2Ffreeradius-server.git

CID 1409874: Always call va_end
---

diff --git a/src/main/log.c b/src/main/log.c
index 4ee5af1b028..4a656fc7d8a 100644
--- a/src/main/log.c
+++ b/src/main/log.c
@@ -541,9 +541,10 @@ void radlog_request_perror(log_type_t type, log_lvl_t lvl, REQUEST *request, cha
 
 		va_start(ap, msg);
 		tmp = talloc_vasprintf(request, msg, ap);
-		if (!tmp) return;
 		va_end(ap);
 
+		if (!tmp) return;
+
 		radlog_request_error(type, lvl, request, "%s: %s", tmp, strerror);
 		talloc_free(tmp);
 	} else {