From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 10 Jan 2014 19:01:04 +0000 (+0100)
Subject: Coverity defect 1151594: side-effect in assertion in CollapsedForwarding
X-Git-Tag: SQUID_3_5_0_1~422
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=432ad89c9b011a9e7a40adc7366eb27a0b93daef;p=thirdparty%2Fsquid.git

Coverity defect 1151594: side-effect in assertion in CollapsedForwarding
---

diff --git a/src/CollapsedForwarding.cc b/src/CollapsedForwarding.cc
index 29c30e5feb..a3aa4a1e80 100644
--- a/src/CollapsedForwarding.cc
+++ b/src/CollapsedForwarding.cc
@@ -110,7 +110,8 @@ CollapsedForwarding::HandleNewData(const char *const when)
         debugs(17, 7, "handled entry " << msg.xitIndex << " in transients_map");
 
         // XXX: stop and schedule an async call to continue
-        assert(++poppedCount < SQUID_MAXFD);
+        ++poppedCount;
+        assert(poppedCount < SQUID_MAXFD);
     }
 }