From: Andoni Duarte Pintado <andoni@isc.org>
Date: Fri, 19 Dec 2025 10:55:30 +0000 (+0100)
Subject: Move "needs: []" to the "quick_checks_job" anchor
X-Git-Tag: v9.21.18~15^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=432b7d7954bc37175c5db20c2f5894214ca0661d;p=thirdparty%2Fbind9.git

Move "needs: []" to the "quick_checks_job" anchor

Most jobs in this stage have it by default, so it makes sense to
add it to their common anchor. Jobs with different "needs:" will
override it.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 96b84170760..7cfe536f5c1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -361,6 +361,7 @@ stages:
   <<: *default_triggering_rules
   <<: *base_image
   stage: quick-checks
+  needs: []
   tags:
     - smalljob
 
@@ -646,7 +647,6 @@ misc:
     # Check dangling symlinks in the repository
     - if find . -xtype l | grep .; then exit 1; fi
     - muon-meson analyze -Werror
-  needs: []
   artifacts:
     paths:
       - checklibs.out
@@ -655,7 +655,6 @@ misc:
 black:
   <<: *quick_checks_job
   <<: *python_triggering_rules
-  needs: []
   script:
     - black $(git ls-files '*.py')
     - git diff > black.patch
@@ -669,7 +668,6 @@ black:
 vulture:
   <<: *quick_checks_job
   <<: *python_triggering_rules
-  needs: []
   script:
     - vulture --exclude "*ans.py,conftest.py,re_compile_checker.py,isctest" --ignore-names "after_servers_start,bootstrap,pytestmark,autouse_*" bin/tests/system/
 
@@ -690,7 +688,6 @@ ci-orphaned-anchors:
   script:
     - *git_clone_bind9-qa
     - bind9-qa/ci-orphaned-anchors/check-orphaned-anchors-ci.py .gitlab-ci.yml
-  needs: []
   rules:
     - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
       changes:
@@ -708,7 +705,6 @@ clang-format:
     - *rule_mr_manual
     - *rule_tag
     - *rule_source_other_than_mr
-  needs: []
   script:
     - if [ -r .clang-format ]; then "${CLANG_FORMAT}" -i -style=file $(git ls-files '*.c' '*.h'); fi
     - git diff > clang-format.patch
@@ -728,7 +724,6 @@ meson-format:
     - *rule_mr_manual
     - *rule_tag
     - *rule_source_other_than_mr
-  needs: []
   script:
     - git ls-files "*meson.build" | xargs muon-meson fmt -i
     - git diff > meson-format.patch
@@ -745,7 +740,6 @@ meson-format:
 
 doctest:
   <<: *quick_checks_job
-  needs: []
   # This script needs to: 1) fail if the doctest fails, 2) fail if
   # the junit.xml file is broken, 3) produce the junit.xml file even if
   # the doctest fails.  Therefore, $RET is used to "cache" the
@@ -773,7 +767,6 @@ doctest:
 pylint:
   <<: *quick_checks_job
   <<: *python_triggering_rules
-  needs: []
   variables:
     PYTHONPATH: "${CI_PROJECT_DIR}/bin/tests/system"
   script:
@@ -783,7 +776,6 @@ pylint:
 
 reuse:
   <<: *quick_checks_job
-  needs: []
   image:
     name: docker.io/fsfe/reuse:latest
     entrypoint: [""]
@@ -793,7 +785,6 @@ reuse:
 shfmt:
   <<: *quick_checks_job
   <<: *shell_triggering_rules
-  needs: []
   script:
     - shfmt -w -i 2 -ci -bn . $(find . -name "*.sh.in")
     - git diff > shfmt.patch
@@ -806,7 +797,6 @@ shfmt:
 
 danger:
   <<: *quick_checks_job
-  needs: []
   script:
     - pip install git+https://gitlab.isc.org/isc-projects/hazard.git
     - hazard
@@ -832,7 +822,6 @@ linkcheck:
       - doc/arm/linkcheck_output/
   rules:
     - if: '$CI_PIPELINE_SOURCE == "schedule"'
-  needs: []
 
 generate-stress-test-configs:
   <<: *quick_checks_job
@@ -842,7 +831,6 @@ generate-stress-test-configs:
   artifacts:
     paths:
       - stress-test-configs.yml
-  needs: []
 
 generate-tsan-stress-test-configs:
   <<: *quick_checks_job
@@ -851,7 +839,6 @@ generate-tsan-stress-test-configs:
   artifacts:
     paths:
       - tsan-stress-test-configs.yml
-  needs: []
   when: manual
 
 # Jobs in the other-checks stage