From: Joel Rosdahl <joel@rosdahl.net>
Date: Sat, 6 Jan 2024 19:21:44 +0000 (+0100)
Subject: fix: Avoid crash for -arch as last compiler option
X-Git-Tag: v4.10~134
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=432e1f5178631aec14a76f8be82c7e090c45bc69;p=thirdparty%2Fccache.git

fix: Avoid crash for -arch as last compiler option

The bug has been present since 89aa39f394e0fa4935e6cadd7184e372a37f9506
(ccache 3.3).

Fixes #1377.
---

diff --git a/src/argprocessing.cpp b/src/argprocessing.cpp
index d1fbae526..b08fac754 100644
--- a/src/argprocessing.cpp
+++ b/src/argprocessing.cpp
@@ -426,6 +426,10 @@ process_option_arg(const Context& ctx,
 
   // Handle -arch options.
   if (arg == "-arch") {
+    if (i == args.size() - 1) {
+      LOG("Missing argument to {}", args[i]);
+      return Statistic::bad_compiler_arguments;
+    }
     ++i;
     args_info.arch_args.emplace_back(args[i]);
     if (args_info.arch_args.size() == 2) {