From: Alan T. DeKok Date: Fri, 17 Sep 2021 12:33:26 +0000 (-0400) Subject: double-check timestamp attributes X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=436230f8806f8be78e39c9435185a4ab62d11796;p=thirdparty%2Ffreeradius-server.git double-check timestamp attributes Most should probably use the "date" data type. --- diff --git a/share/dictionary/radius/dictionary.3com b/share/dictionary/radius/dictionary.3com index bffbda4e3c..291e9a5d07 100644 --- a/share/dictionary/radius/dictionary.3com +++ b/share/dictionary/radius/dictionary.3com @@ -50,7 +50,7 @@ ATTRIBUTE End-Date 7 string ATTRIBUTE URL 8 string ATTRIBUTE Connect_Id 26 integer -ATTRIBUTE NAS-Startup-Timestamp 59 integer +ATTRIBUTE NAS-Startup-Timestamp 59 date ATTRIBUTE Ip-Host-Addr 60 string ATTRIBUTE Product-ID 255 string diff --git a/share/dictionary/radius/dictionary.3gpp2 b/share/dictionary/radius/dictionary.3gpp2 index d6cca4168e..8277876eb9 100644 --- a/share/dictionary/radius/dictionary.3gpp2 +++ b/share/dictionary/radius/dictionary.3gpp2 @@ -120,7 +120,7 @@ ATTRIBUTE DNS-Update-Required 75 integer # 77 ? #ATTRIBUTE Always-On 78 integer ATTRIBUTE Foreign-Agent-Address 79 ipaddr -ATTRIBUTE Last-User-Activity-Time 80 integer +ATTRIBUTE Last-User-Activity-Time 80 date ATTRIBUTE MN-AAA-Removal-Indication 81 integer ATTRIBUTE RN-Packet-Data-Inactivity-Timer 82 integer ATTRIBUTE Forward-PDCH-RC 83 integer diff --git a/share/dictionary/radius/dictionary.broadsoft b/share/dictionary/radius/dictionary.broadsoft index b2db36e796..674035bb5e 100644 --- a/share/dictionary/radius/dictionary.broadsoft +++ b/share/dictionary/radius/dictionary.broadsoft @@ -223,8 +223,8 @@ ATTRIBUTE Called-Asserted-Identity 208 string ATTRIBUTE Called-Asserted-Pres-Indicator 209 string ATTRIBUTE SDP 210 string ATTRIBUTE Media-Initiator-Flag 211 string -ATTRIBUTE SDP-Offer-Timestamp 212 string -ATTRIBUTE SDP-Answer-Timestamp 213 string +ATTRIBUTE SDP-Offer-Timestamp 212 string # should probably be date? +ATTRIBUTE SDP-Answer-Timestamp 213 string # should probably be date? ATTRIBUTE Early-Media-SDP 214 string ATTRIBUTE Early-Media-Initiator-Flag 215 string ATTRIBUTE Body-Content-Type 216 string diff --git a/share/dictionary/radius/dictionary.h3c b/share/dictionary/radius/dictionary.h3c index d725b1292f..62eeec9726 100644 --- a/share/dictionary/radius/dictionary.h3c +++ b/share/dictionary/radius/dictionary.h3c @@ -47,7 +47,7 @@ VALUE Exec-Privilege Manage 3 ATTRIBUTE NAT-IP-Address 32 ipaddr ATTRIBUTE NAT-Start-Port 33 integer ATTRIBUTE NAT-End-Port 34 integer -ATTRIBUTE NAS-Startup-Timestamp 59 integer +ATTRIBUTE NAS-Startup-Timestamp 59 date ATTRIBUTE Ip-Host-Addr 60 string ATTRIBUTE User-Notify 61 string ATTRIBUTE User-HeartBeat 62 string diff --git a/share/dictionary/radius/dictionary.shiva b/share/dictionary/radius/dictionary.shiva index ce2f86e65c..584cf09243 100644 --- a/share/dictionary/radius/dictionary.shiva +++ b/share/dictionary/radius/dictionary.shiva @@ -50,7 +50,7 @@ ATTRIBUTE LAT-Port 43 string ATTRIBUTE Max-VCs 44 integer ATTRIBUTE DHCP-Leasetime 45 integer ATTRIBUTE LAT-Groups 46 string -ATTRIBUTE RTC-Timestamp 60 integer +ATTRIBUTE RTC-Timestamp 60 integer # should probably be date? ATTRIBUTE Circuit-Type 61 integer ATTRIBUTE Called-Number 90 string ATTRIBUTE Calling-Number 91 string diff --git a/share/dictionary/radius/dictionary.travelping b/share/dictionary/radius/dictionary.travelping index 310d8d7b82..6a180c99e0 100644 --- a/share/dictionary/radius/dictionary.travelping +++ b/share/dictionary/radius/dictionary.travelping @@ -45,7 +45,7 @@ ATTRIBUTE NAT-Port-End 29 integer ATTRIBUTE Keep-Alive-Timeout 30 integer ATTRIBUTE TLS-Auth-Type 31 integer ATTRIBUTE TLS-Pre-Shared-Key 32 string -ATTRIBUTE CAPWAP-Timestamp 33 integer +ATTRIBUTE CAPWAP-Timestamp 33 integer # should probably be date? ATTRIBUTE CAPWAP-WVersion 34 string ATTRIBUTE CAPWAP-Session-Id 35 octets ATTRIBUTE CAPWAP-Radio-Id 36 integer @@ -67,7 +67,7 @@ ATTRIBUTE CAPWAP-GPS-Latitude 51 string ATTRIBUTE CAPWAP-GPS-Longitude 52 string ATTRIBUTE CAPWAP-GPS-Altitude 53 string ATTRIBUTE CAPWAP-GPS-Hdop 54 string -ATTRIBUTE CAPWAP-GPS-Timestamp 55 string +ATTRIBUTE CAPWAP-GPS-Timestamp 55 string # should probably be date? ATTRIBUTE CAPWAP-Hardware-Version 56 string ATTRIBUTE CAPWAP-Software-Version 57 string ATTRIBUTE CAPWAP-Boot-Version 58 string diff --git a/share/dictionary/radius/dictionary.usr b/share/dictionary/radius/dictionary.usr index 0899ea6964..027f36b1e9 100644 --- a/share/dictionary/radius/dictionary.usr +++ b/share/dictionary/radius/dictionary.usr @@ -422,7 +422,7 @@ ATTRIBUTE Policy-Type 0x9884 integer ATTRIBUTE Mobile-Session-ID 0x9885 integer ATTRIBUTE Mobile-Accounting-Type 0x9886 integer ATTRIBUTE Mobile-Service-Option 0x9887 integer -ATTRIBUTE Wallclock-Timestamp 0x9888 integer +ATTRIBUTE Wallclock-Timestamp 0x9888 integer # should probably be date? ATTRIBUTE Dvmrp-Initial-Flooding 0x988a integer ATTRIBUTE Telnet-Options 0x988c integer ATTRIBUTE CDMA-PktData-Network-ID 0x988d integer