From: Phil Sutter <phil@nwl.cc>
Date: Thu, 17 Aug 2017 17:09:32 +0000 (+0200)
Subject: tipc/node: Fix socket fd check in cmd_node_get_addr()
X-Git-Tag: v4.13.0~71
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=436270a45dea2fe5dbc4680f9c8e31f07d167f20;p=thirdparty%2Fiproute2.git

tipc/node: Fix socket fd check in cmd_node_get_addr()

socket() returns -1 on error, not 0.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/tipc/node.c b/tipc/node.c
index 201fe1a4d..fe085aec9 100644
--- a/tipc/node.c
+++ b/tipc/node.c
@@ -109,7 +109,8 @@ static int cmd_node_get_addr(struct nlmsghdr *nlh, const struct cmd *cmd,
 	socklen_t sz = sizeof(struct sockaddr_tipc);
 	struct sockaddr_tipc addr;
 
-	if (!(sk = socket(AF_TIPC, SOCK_RDM, 0))) {
+	sk = socket(AF_TIPC, SOCK_RDM, 0);
+	if (sk < 0) {
 		fprintf(stderr, "opening TIPC socket: %s\n", strerror(errno));
 		return -1;
 	}