From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 4 Jun 2019 11:52:21 +0000 (+0200)
Subject: qemu-bridge-helper: Document known shortcomings
X-Git-Tag: v4.1.0-rc0~29^2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=436e3530763cb1e9c65d9575a9809f29ca3ef7e5;p=thirdparty%2Fqemu.git

qemu-bridge-helper: Document known shortcomings

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---

diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index f9940deefd5..95624bc3005 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -10,7 +10,17 @@
  *
  * This work is licensed under the terms of the GNU GPL, version 2.  See
  * the COPYING file in the top-level directory.
- *
+ */
+
+/*
+ * Known shortcomings:
+ * - There is no manual page
+ * - The syntax of the ACL file is not documented anywhere
+ * - parse_acl_file() doesn't report fopen() failure properly, fails
+ *   to check ferror() after fgets() failure, arbitrarily truncates
+ *   long lines, handles whitespace inconsistently, error messages
+ *   don't point to the offending file and line, errors in included
+ *   files are reported, but otherwise ignored, ...
  */
 
 #include "qemu/osdep.h"