From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 14 Nov 2016 17:54:02 +0000 (-0500)
Subject: don't put business logic into an assertion
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=437794111cc0f0fe256060cb31f53ecba1db4636;p=thirdparty%2Ffreeradius-server.git

don't put business logic into an assertion
---

diff --git a/src/modules/rlm_lua/rlm_lua.c b/src/modules/rlm_lua/rlm_lua.c
index 63381286512..6be707a6721 100644
--- a/src/modules/rlm_lua/rlm_lua.c
+++ b/src/modules/rlm_lua/rlm_lua.c
@@ -85,7 +85,8 @@ static void _tls_interp_destroy(void *ctx)
 	 *	we free this context, which should in turn call a destructor which will
 	 *	call lua_close and free the actual interpreter.
 	 */
-	rad_assert(inst = talloc_find_parent_bytype(marker, rlm_lua_t));
+	inst = talloc_find_parent_bytype(marker, rlm_lua_t);
+	rad_assert(inst != NULL);
 	pthread_mutex_lock(inst->mutex);
 	talloc_free(marker);
 	pthread_mutex_unlock(inst->mutex);