From: James Jones <jejones3141@gmail.com>
Date: Wed, 22 Jun 2022 21:09:38 +0000 (-0500)
Subject: Wrap unchecked value box calls in xlat_idna() in MEM() (CID #1503962) (#4578)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43875ceda00e9b6de199212b5479adf054f5d70a;p=thirdparty%2Ffreeradius-server.git

Wrap unchecked value box calls in xlat_idna() in MEM() (CID #1503962) (#4578)
---

diff --git a/src/modules/rlm_idn/rlm_idn.c b/src/modules/rlm_idn/rlm_idn.c
index 99936efa093..65ab6a2a08f 100644
--- a/src/modules/rlm_idn/rlm_idn.c
+++ b/src/modules/rlm_idn/rlm_idn.c
@@ -136,8 +136,8 @@ static xlat_action_t xlat_idna(TALLOC_CTX *ctx, fr_dcursor_t *out,
 		return XLAT_ACTION_FAIL;
 	}
 
-	vb = fr_value_box_alloc_null(ctx);
-	fr_value_box_strdup(ctx, vb, NULL, idna, false);
+	MEM(vb = fr_value_box_alloc_null(ctx));
+	MEM(fr_value_box_strdup(ctx, vb, NULL, idna, false) >= 0);
 	fr_dcursor_append(out, vb);
 	free(idna);