From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 18 Feb 2026 01:53:57 +0000 (+0900)
Subject: bootspec: add missing else
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43c4ecc95135e3ec68a13200c38d3f05e81ad6bf;p=thirdparty%2Fsystemd.git

bootspec: add missing else

Otherwise, OOM error will never checked, and the "preferred" setting
always emits warning that the field is unknown.

Follow-up for 450e0dce02d754d7af599dd99ab40b9363072760.
Fixes CID#1645063.
---

diff --git a/src/shared/bootspec.c b/src/shared/bootspec.c
index 89dfae70c96..d8ce45475f5 100644
--- a/src/shared/bootspec.c
+++ b/src/shared/bootspec.c
@@ -519,7 +519,7 @@ int boot_loader_read_conf(BootConfig *config, FILE *file, const char *path) {
 
                 if (streq(field, "preferred"))
                         r = free_and_strdup(&config->preferred_pattern, p);
-                if (streq(field, "default"))
+                else if (streq(field, "default"))
                         r = free_and_strdup(&config->default_pattern, p);
                 else if (STR_IN_SET(field, "timeout", "editor", "auto-entries", "auto-firmware",
                                     "auto-poweroff", "auto-reboot", "beep", "reboot-for-bitlocker",