From: Boris Fiuczynski <fiuczy@linux.ibm.com>
Date: Thu, 10 Dec 2020 17:32:36 +0000 (+0100)
Subject: node_device: pacify grumpy coverity due to addr override
X-Git-Tag: v7.0.0-rc1~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43cc9b001138310bb6df8964c65abdfc1b59cb0c;p=thirdparty%2Flibvirt.git

node_device: pacify grumpy coverity due to addr override

With commit 09364608b4 node_device: refactor address retrieval of node device
"if-else if" was replaced by "switch".
The contained break statement now is no longer in context of the for loop
but instead of the switch causing the legitimate grumpiness of coverity.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Suggested-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c
index e254b49244..51b20848ce 100644
--- a/src/node_device/node_device_driver.c
+++ b/src/node_device/node_device_driver.c
@@ -687,6 +687,9 @@ nodeDeviceFindAddressByName(const char *name)
         case VIR_NODE_DEV_CAP_LAST:
             break;
         }
+
+        if (addr)
+            break;
     }
 
     virNodeDeviceObjEndAPI(&dev);