From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 28 Oct 2010 15:22:31 +0000 (+0200)
Subject: Bug 607966: Use of qw(...) as parentheses is deprecated since Perl 5.13.5
X-Git-Tag: bugzilla-4.0rc1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43d51c6dcc08b32d442a43ebe1f802ccab717b8a;p=thirdparty%2Fbugzilla.git

Bug 607966: Use of qw(...) as parentheses is deprecated since Perl 5.13.5
r=gerv a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 7732d7d5fe..18a70d0e5f 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1464,7 +1464,7 @@ sub _check_dependencies {
 
     my %deps_in = (dependson => $depends_on || '', blocked => $blocks || '');
 
-    foreach my $type qw(dependson blocked) {
+    foreach my $type (qw(dependson blocked)) {
         my @bug_ids = ref($deps_in{$type}) 
             ? @{$deps_in{$type}} 
             : split(/[\s,]+/, $deps_in{$type});
diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index 9355ef7dd4..6b60095170 100644
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -171,9 +171,7 @@ sub clean_search_url {
     foreach my $num (1,2,3) {
         # If there's no value in the email field, delete the related fields.
         if (!$self->param("email$num")) {
-            foreach my $field qw(type assigned_to reporter qa_contact
-                                 cc longdesc) 
-            {
+            foreach my $field (qw(type assigned_to reporter qa_contact cc longdesc)) {
                 $self->delete("email$field$num");
             }
         }
diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index 10a7e786e4..a50a75e4de 100644
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -927,7 +927,7 @@ sub _attachment_to_hash {
 
     # creator/attacher require an extra lookup, so we only send them if
     # the filter wants them.
-    foreach my $field qw(creator attacher) {
+    foreach my $field (qw(creator attacher)) {
         if (filter_wants $filters, $field) {
             $item->{$field} = $self->type('string', $attach->attacher->login);
         }
diff --git a/chart.cgi b/chart.cgi
index dcd83cb01e..12ef8d8345 100755
--- a/chart.cgi
+++ b/chart.cgi
@@ -200,7 +200,7 @@ elsif ($action eq "delete") {
 
     $series->remove_from_db();
     # Remove (sub)categories which no longer have any series.
-    foreach my $cat qw(category subcategory) {
+    foreach my $cat (qw(category subcategory)) {
         my $is_used = $dbh->selectrow_array("SELECT COUNT(*) FROM series WHERE $cat = ?",
                                              undef, $series->{"${cat}_id"});
         if (!$is_used) {
diff --git a/xt/lib/Bugzilla/Test/Search.pm b/xt/lib/Bugzilla/Test/Search.pm
index 72c3828064..38004134cf 100644
--- a/xt/lib/Bugzilla/Test/Search.pm
+++ b/xt/lib/Bugzilla/Test/Search.pm
@@ -373,7 +373,7 @@ sub _create_field_values {
 
     $values{'keywords'} = create_keyword($number)->name;
 
-    foreach my $field qw(assigned_to qa_contact reporter cc) {
+    foreach my $field (qw(assigned_to qa_contact reporter cc)) {
         $values{$field} = create_user("$number-$field")->login;
     }
 
@@ -497,7 +497,7 @@ sub _create_flags {
     my $flagtypes = _create_flagtypes($number);
 
     my %flags;
-    foreach my $type qw(a b) {
+    foreach my $type (qw(a b)) {
         $flags{$type} = _get_flag_values(@_, $flagtypes->{$type});
     }
     return \%flags;
@@ -607,9 +607,9 @@ sub _create_one_bug {
     
     # These are necessary for the changedfrom tests.
     my $extra_values = $self->_extra_bug_create_values->{$number};
-    foreach my $field qw(comments remaining_time percentage_complete
+    foreach my $field (qw(comments remaining_time percentage_complete
                          keyword_objects everconfirmed dependson blocked
-                         groups_in classification)
+                         groups_in classification))
     {
         $extra_values->{$field} = $bug->$field;
     }