From: Seth Michael Larson Date: Sat, 17 Aug 2019 18:19:08 +0000 (-0500) Subject: Skip coverage on breaks right before returns for Python 3.8 (#226) X-Git-Tag: 0.7.0~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43f66d575619d61caeb44ba7fe1bd7598ea6e7fd;p=thirdparty%2Fhttpx.git Skip coverage on breaks right before returns for Python 3.8 (#226) --- diff --git a/.travis.yml b/.travis.yml index d702022c..4db0a0df 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,9 +22,6 @@ matrix: - python: 3.8-dev env: NOX_SESSION=test-3.8 - allow_failures: - - python: 3.8-dev - install: - pip install --upgrade nox diff --git a/httpx/config.py b/httpx/config.py index 6d427b85..796da350 100644 --- a/httpx/config.py +++ b/httpx/config.py @@ -148,7 +148,7 @@ class SSLConfig: if ssl.HAS_ALPN: context.set_alpn_protocols(["h2", "http/1.1"]) - if ssl.HAS_NPN: + if ssl.HAS_NPN: # pragma: no cover context.set_npn_protocols(["h2", "http/1.1"]) return context diff --git a/httpx/dispatch/http11.py b/httpx/dispatch/http11.py index 0f34191e..623ac1df 100644 --- a/httpx/dispatch/http11.py +++ b/httpx/dispatch/http11.py @@ -129,7 +129,7 @@ class HTTP11Connection: continue else: assert isinstance(event, h11.Response) - break + break # pragma: no cover http_version = "HTTP/%s" % event.http_version.decode("latin-1", errors="ignore") return http_version, event.status_code, event.headers @@ -145,7 +145,7 @@ class HTTP11Connection: yield bytes(event.data) else: assert isinstance(event, h11.EndOfMessage) - break + break # pragma: no cover async def _receive_event(self, timeout: TimeoutConfig = None) -> H11Event: """ @@ -162,7 +162,8 @@ class HTTP11Connection: data = b"" self.h11_state.receive_data(data) else: - break + assert event is not h11.NEED_DATA + break # pragma: no cover return event async def response_closed(self) -> None: