From: Jeff Layton <jlayton@kernel.org>
Date: Sun, 9 Feb 2025 12:31:24 +0000 (-0500)
Subject: nfsd: always release slot when requeueing callback
X-Git-Tag: v6.15-rc1~88^2~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=43fa8905db08a39d4d0a709f6f3294037c4db425;p=thirdparty%2Flinux.git

nfsd: always release slot when requeueing callback

If the callback is going to be requeued to the workqueue, then release
the slot. The callback client and session could change and the slot may
no longer be valid after that point.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 5eabba4cc6c5e..640d788052fd0 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1405,6 +1405,7 @@ retry_nowait:
 	rpc_restart_call_prepare(task);
 	goto out;
 requeue:
+	nfsd41_cb_release_slot(cb);
 	nfsd4_requeue_cb(task, cb);
 	return false;
 }