From: Andrea Bolognani <abologna@redhat.com>
Date: Tue, 25 Apr 2023 13:33:02 +0000 (+0200)
Subject: util: Improve comment for workaround
X-Git-Tag: v9.4.0-rc1~107
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4419e74117b3bb17c61cd7a612b5801ab99ad547;p=thirdparty%2Flibvirt.git

util: Improve comment for workaround

Now that a version of GLib that contains the fix has been
released, it's more useful to record that information. Adding
a TODO annotation makes the whole thing easily greppable.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/util/virfile.c b/src/util/virfile.c
index 657e74e026..228482e8f8 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file)
         return NULL;
 
     /* Workaround for a bug in g_find_program_in_path() not returning absolute
-     * path as documented.  This has been fixed in
-     * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127
+     * path as documented. TODO drop it once we require GLib >= 2.69.0
      */
     return g_canonicalize_filename(path, NULL);
 }