From: Willy Tarreau <w@1wt.eu>
Date: Mon, 14 Sep 2020 06:43:51 +0000 (+0200)
Subject: BUILD: connection: fix build on clang after the VAR_ARRAY cleanup
X-Git-Tag: v2.3-dev5~97
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=441b6c31e;p=thirdparty%2Fhaproxy.git

BUILD: connection: fix build on clang after the VAR_ARRAY cleanup

Commit 4987a4744 ("CLEANUP: tree-wide: use VAR_ARRAY instead of [0] in
various definitions") broke the build on clang due to the tlv field used
to receive/send the proxy protocol. The problem is that struct tlv is
included at the beginning of struct tlv_ssl, which doesn't make much
sense. In fact the value[] array isn't really a var array but just an
end of struct marker, and must really be an array of size zero.
---

diff --git a/include/haproxy/connection-t.h b/include/haproxy/connection-t.h
index 3aab5d05ef..9caa2ca499 100644
--- a/include/haproxy/connection-t.h
+++ b/include/haproxy/connection-t.h
@@ -589,7 +589,7 @@ struct tlv {
 	uint8_t type;
 	uint8_t length_hi;
 	uint8_t length_lo;
-	uint8_t value[VAR_ARRAY];
+	uint8_t value[0];
 }__attribute__((packed));
 
 struct tlv_ssl {