From: Willem Toorop <willem@nlnetlabs.nl>
Date: Tue, 29 Nov 2016 13:45:10 +0000 (+0100)
Subject: Dangling else issie in close_socket define
X-Git-Tag: release-1.7.0-rc1~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=443ade7795abfaea8cc8313b3e01c8c90cdc728b;p=thirdparty%2Fldns.git

Dangling else issie in close_socket define

Wouter's Review
---

diff --git a/configure.ac b/configure.ac
index 19a3847e..5afca793 100644
--- a/configure.ac
+++ b/configure.ac
@@ -882,10 +882,10 @@ size_t strlcpy(char *dst, const char *src, size_t siz);
 
 #ifdef USE_WINSOCK
 #define SOCK_INVALID INVALID_SOCKET
-#define close_socket(_s) if (_s > SOCK_INVALID) {closesocket(_s); _s = SOCK_INVALID;}
+#define close_socket(_s) do { if (_s > SOCK_INVALID) {closesocket(_s); _s = SOCK_INVALID;} } while(0)
 #else
 #define SOCK_INVALID -1
-#define close_socket(_s) if (_s > SOCK_INVALID) {close(_s); _s = SOCK_INVALID;}
+#define close_socket(_s) do { if (_s > SOCK_INVALID) {close(_s); _s = SOCK_INVALID;} } while(0)
 #endif
 
 #ifdef __cplusplus