From: Andrei Pavel <andrei@isc.org>
Date: Thu, 16 Feb 2023 13:33:54 +0000 (+0200)
Subject: [#2402] remove the regex check in statusGet UT
X-Git-Tag: Kea-2.3.5~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4440d12da3ebecd1f19d48119df9b1fbdd61fe33;p=thirdparty%2Fkea.git

[#2402] remove the regex check in statusGet UT

It caused failures on CentOS 7 and FreeBSDs 12 and 13.

unknown file: Failure
C++ exception with description "regex_error" thrown in the test body.
[  FAILED  ] CtrlChannelDhcpv4SrvTest.statusGet (3 ms)
---

diff --git a/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc b/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
index 46072020e4..87ea2ea0d3 100644
--- a/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
+++ b/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
@@ -36,7 +36,6 @@
 
 #include <fstream>
 #include <iomanip>
-#include <regex>
 #include <sstream>
 #include <thread>
 
@@ -1154,8 +1153,7 @@ TEST_F(CtrlChannelDhcpv4SrvTest, statusGet) {
 
     auto found_queue_stats = arguments->get("packet-queue-statistics");
     ASSERT_TRUE(found_queue_stats);
-    EXPECT_TRUE(regex_match(found_queue_stats->str(),
-                            regex("[ 0\\.[0-9]+, 0\\.[0-9]+, 0\\.[0-9]+ ]")));
+    EXPECT_FALSE(found_queue_stats->str().empty());
 
     MultiThreadingMgr::instance().setMode(true);
     MultiThreadingMgr::instance().setThreadPoolSize(4);
diff --git a/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc b/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
index 66591feb24..d6a3465543 100644
--- a/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
+++ b/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
@@ -33,7 +33,6 @@
 
 #include <fstream>
 #include <iomanip>
-#include <regex>
 #include <sstream>
 #include <thread>
 
@@ -1049,8 +1048,7 @@ TEST_F(CtrlChannelDhcpv6SrvTest, statusGet) {
 
     auto found_queue_stats = arguments->get("packet-queue-statistics");
     ASSERT_TRUE(found_queue_stats);
-    EXPECT_TRUE(regex_match(found_queue_stats->str(),
-                            regex("[ 0\\.[0-9]+, 0\\.[0-9]+, 0\\.[0-9]+ ]")));
+    EXPECT_FALSE(found_queue_stats->str().empty());
 
     MultiThreadingMgr::instance().setMode(true);
     MultiThreadingMgr::instance().setThreadPoolSize(4);