From: Willy Tarreau <w@1wt.eu>
Date: Wed, 21 Nov 2012 22:37:37 +0000 (+0100)
Subject: DOC: documentation on http header capture is wrong
X-Git-Tag: v1.5-dev13~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4460d033b381288f7f43d5809435e216f01744d8;p=thirdparty%2Fhaproxy.git

DOC: documentation on http header capture is wrong

Since commit it is said that only the first value of the first occurrence
of a header is captured. This is wrong. Since the introduction of header
captures in version 1.1 in 2005 (commit e983144d), the WHOLE line of the
LAST occurrence has been captured and the behaviour has never changed.

At this time the doc was correct. The error was introduced in the new doc
in 1.3.14 in 2007 (commit 0ba27505).

So this fix should be backported to 1.4 and 1.3.
---

diff --git a/doc/configuration.txt b/doc/configuration.txt
index 3af744419a..b5b22c9b74 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -1748,7 +1748,7 @@ capture cookie <name> len <length>
 
 
 capture request header <name> len <length>
-  Capture and log the first occurrence of the specified request header.
+  Capture and log the last occurrence of the specified request header.
   May be used in sections :   defaults | frontend | listen | backend
                                   no   |    yes   |   yes  |   no
   Arguments :
@@ -1762,7 +1762,7 @@ capture request header <name> len <length>
               report in the logs. The string will be truncated on the right if
               it exceeds <length>.
 
-  Only the first value of the last occurrence of the header is captured. The
+  The complete value of the last occurrence of the header is captured. The
   value will be added to the logs between braces ('{}'). If multiple headers
   are captured, they will be delimited by a vertical bar ('|') and will appear
   in the same order they were declared in the configuration. Non-existent
@@ -1792,7 +1792,7 @@ capture request header <name> len <length>
 
 
 capture response header <name> len <length>
-  Capture and log the first occurrence of the specified response header.
+  Capture and log the last occurrence of the specified response header.
   May be used in sections :   defaults | frontend | listen | backend
                                   no   |    yes   |   yes  |   no
   Arguments :
@@ -1806,7 +1806,7 @@ capture response header <name> len <length>
               report in the logs. The string will be truncated on the right if
               it exceeds <length>.
 
-  Only the first value of the last occurrence of the header is captured. The
+  The complete value of the last occurrence of the header is captured. The
   result will be added to the logs between braces ('{}') after the captured
   request headers. If multiple headers are captured, they will be delimited by
   a vertical bar ('|') and will appear in the same order they were declared in