From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Wed, 6 Mar 2019 12:36:33 +0000 (+0100)
Subject: DNAME: add some comments to the unit tests
X-Git-Tag: rec-4.2.0-beta1~6^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=44671635761cc86b789cfcfc31c4b32b009d9706;p=thirdparty%2Fpdns.git

DNAME: add some comments to the unit tests
---

diff --git a/pdns/recursordist/test-syncres_cc.cc b/pdns/recursordist/test-syncres_cc.cc
index cba955f3c9..fbdb287a5b 100644
--- a/pdns/recursordist/test-syncres_cc.cc
+++ b/pdns/recursordist/test-syncres_cc.cc
@@ -11000,7 +11000,7 @@ BOOST_AUTO_TEST_CASE(test_dname_dnssec_secure) {
           setLWResult(res, 0, true, false, false);
           addRecordToLW(res, dnameOwner, QType::DNAME, dnameTarget.toString());
           addRRSIG(keys, res->d_records, dnameOwner, 300);
-          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString());
+          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString()); // CNAME from a DNAME is not signed
           return 1;
         }
       } else if (ip == ComboAddress("192.0.2.2:53")) {
@@ -11152,7 +11152,7 @@ BOOST_AUTO_TEST_CASE(test_dname_dnssec_insecure) {
           setLWResult(res, 0, true, false, false);
           addRecordToLW(res, dnameOwner, QType::DNAME, dnameTarget.toString());
           addRRSIG(keys, res->d_records, dnameOwner, 300);
-          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString());
+          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString()); // CNAME from a DNAME is not signed
           return 1;
         }
       } else if (ip == ComboAddress("192.0.2.2:53")) {