From: Mats Klepsland <mats.klepsland@gmail.com>
Date: Fri, 21 Sep 2018 05:25:19 +0000 (+0200)
Subject: app-layer-ssl: remove unnecessary length check
X-Git-Tag: suricata-4.1.0-rc2~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4470b05ae4eb1c6626e0e92ae05d6c0693a4f103;p=thirdparty%2Fsuricata.git

app-layer-ssl: remove unnecessary length check

We already check that empty extensions are not decoded, so this length
check is not needed.
---

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index 4577c1d4c8..bd5833998d 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -1184,8 +1184,7 @@ static inline int TLSDecodeHSHelloExtensions(SSLState *ssl_state,
 
             case SSL_EXTENSION_SESSION_TICKET:
             {
-                if ((ssl_state->current_flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) &&
-                        ext_len != 0) {
+                if (ssl_state->current_flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) {
                     /* This has to be verified later on by checking if a
                        certificate record has been sent by the server. */
                     ssl_state->flags |= SSL_AL_FLAG_SESSION_RESUMED;