From: Mark Andrews Date: Wed, 5 Feb 2020 05:41:03 +0000 (+1100) Subject: 'tql' must be non NULL, remove test. X-Git-Tag: v9.16.0~29^2~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=44b08521ef11e550ec5edea7378458aad8f2a89f;p=thirdparty%2Fbind9.git 'tql' must be non NULL, remove test. 255 flag_fail: 256 /* get rid of what was build of the query list */ CID 1452697 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking tql suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 257 if (tql != NULL) 258 destroy_querylist(mctx, &tql); --- diff --git a/contrib/dlz/drivers/sdlz_helper.c b/contrib/dlz/drivers/sdlz_helper.c index 889a8a6ee87..6eb66292457 100644 --- a/contrib/dlz/drivers/sdlz_helper.c +++ b/contrib/dlz/drivers/sdlz_helper.c @@ -254,8 +254,7 @@ build_querylist(isc_mem_t *mctx, const char *query_str, char **zone, flag_fail: /* get rid of what was build of the query list */ - if (tql != NULL) - destroy_querylist(mctx, &tql); + destroy_querylist(mctx, &tql); return result; }