From: Mark Michelson Date: Thu, 1 May 2014 15:41:43 +0000 (+0000) Subject: Remove unnecessary repetition checks from res_pjsip_exten_state X-Git-Tag: 12.3.0-rc1~43 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=44b5ac115fe85763727dc31777dd0f1d9e196142;p=thirdparty%2Fasterisk.git Remove unnecessary repetition checks from res_pjsip_exten_state The PBX core already takes care of ensuring that repeated state changes are not communicated to exten state consumers. Because the check in res_pjsip_exten_state was incomplete, it was causing valid presence state changes not to be sent out. For instance, if the presence state did not change but the message or subtype did, then no presence-related NOTIFY request would be sent out. closes issue ASTERISK-23672 Reported by Mark Michelson git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@413173 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/res/res_pjsip_exten_state.c b/res/res_pjsip_exten_state.c index 7742de4250..7a90679391 100644 --- a/res/res_pjsip_exten_state.c +++ b/res/res_pjsip_exten_state.c @@ -334,11 +334,6 @@ static int state_changed(char *context, char *exten, struct notify_task_data *task_data; struct exten_state_subscription *exten_state_sub = data; - if (exten_state_sub->last_exten_state == info->exten_state && - exten_state_sub->last_presence_state == info->presence_state) { - return 0; - } - if (!(task_data = alloc_notify_task_data(exten, exten_state_sub, info))) { return -1; }