From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Thu, 6 Jun 2013 13:35:31 +0000 (+0100)
Subject: Remove endless counter incrementing.
X-Git-Tag: 0.5.6~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=44fbf9709b76d89db14f8dba0cc7ca15fb3e7954;p=thirdparty%2Frspamd.git

Remove endless counter incrementing.

In some cases it is not enough to perform compare and exchange
and we still can get race condition in atomic incrementing.
Therefore, it is better to loose a history event than to
log error message each time.
---

diff --git a/src/roll_history.c b/src/roll_history.c
index 69f1417628..4206a6a8b9 100644
--- a/src/roll_history.c
+++ b/src/roll_history.c
@@ -101,7 +101,8 @@ rspamd_roll_history_update (struct roll_history *history, struct worker_task *ta
 		row->completed = FALSE;
 	}
 	else {
-		msg_err ("internal error with history roll occured, row number is invalid: %d", row_num);
+		/* Race condition */
+		history->cur_row = 0;
 		return;
 	}