From: Victor Julien <vjulien@oisf.net>
Date: Sat, 4 Jun 2022 06:49:41 +0000 (+0200)
Subject: smtp: turn assertions in to debug asserts
X-Git-Tag: suricata-6.0.6~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45083caf81137a64668a2f30c5b8f1f0875247bf;p=thirdparty%2Fsuricata.git

smtp: turn assertions in to debug asserts

(cherry picked from commit 77fae275efb54221d9cf3badd25df38eb1ea0b86)
---

diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index 700122cf8d..791f645231 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -1290,7 +1290,7 @@ static AppLayerResult SMTPParse(int direction, Flow *f, SMTPState *state,
     /* toserver */
     if (direction == 0) {
         while (res.status == 0) {
-            BUG_ON(state->discard_till_lf);
+            DEBUG_VALIDATE_BUG_ON(state->discard_till_lf);
             if (!state->discard_till_lf) {
                 if ((state->current_line_delimiter_len > 0) &&
                         (SMTPProcessRequest(state, f, pstate) == -1))
@@ -1310,7 +1310,7 @@ static AppLayerResult SMTPParse(int direction, Flow *f, SMTPState *state,
         /* toclient */
     } else {
         while (res.status == 0) {
-            BUG_ON(state->discard_till_lf);
+            DEBUG_VALIDATE_BUG_ON(state->discard_till_lf);
             if (!state->discard_till_lf) {
                 if ((state->current_line_delimiter_len > 0) &&
                         (SMTPProcessReply(state, f, pstate, thread_data) == -1))