From: Nikos Mavrogiannopoulos <nmav@redhat.com>
Date: Thu, 21 May 2015 08:41:11 +0000 (+0200)
Subject: ecc ext: check return code of _gnutls_buffer_append_data
X-Git-Tag: gnutls_3_4_2~82
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45157d59af50be5a6d5d6ee848df59205fbb67df;p=thirdparty%2Fgnutls.git

ecc ext: check return code of _gnutls_buffer_append_data
---

diff --git a/lib/ext/ecc.c b/lib/ext/ecc.c
index ee13db6ac9..68b3f89542 100644
--- a/lib/ext/ecc.c
+++ b/lib/ext/ecc.c
@@ -32,10 +32,6 @@
 #include <gnutls_num.h>
 #include <algorithms.h>
 
-/* Maps record size to numbers according to the
- * extensions draft.
- */
-
 static int _gnutls_supported_ecc_recv_params(gnutls_session_t session,
 					     const uint8_t * data,
 					     size_t data_size);
@@ -254,13 +250,17 @@ _gnutls_supported_ecc_pf_send_params(gnutls_session_t session,
 				     gnutls_buffer_st * extdata)
 {
 	const uint8_t p[2] = { 0x01, 0x00 };	/* only support uncompressed point format */
+	int ret;
 
 	if (session->security_parameters.entity == GNUTLS_SERVER
 	    && !_gnutls_session_is_ecc(session))
 		return 0;
 
 	if (session->internals.priorities.supported_ecc.algorithms > 0) {
-		_gnutls_buffer_append_data(extdata, p, 2);
+		ret = _gnutls_buffer_append_data(extdata, p, 2);
+		if (ret < 0)
+			return gnutls_assert_val(ret);
+
 		return 2;
 	}
 	return 0;