From: Marcin Siodelski <marcin@isc.org>
Date: Tue, 11 Dec 2018 19:23:10 +0000 (+0100)
Subject: [master] Fixed the IfaceMgr code which missed negation in error condition.
X-Git-Tag: 343-put-socket-control-buffer-in-the-stack_base~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45279c9d17611789ea0c7b02e4998b17c4e016b5;p=thirdparty%2Fkea.git

[master] Fixed the IfaceMgr code which missed negation in error condition.

Agreed on jabber.
---

diff --git a/src/lib/dhcp/iface_mgr.cc b/src/lib/dhcp/iface_mgr.cc
index 6142624a4f..ff90384beb 100644
--- a/src/lib/dhcp/iface_mgr.cc
+++ b/src/lib/dhcp/iface_mgr.cc
@@ -516,7 +516,7 @@ IfaceMgr::openSockets4(const uint16_t port, const bool use_bcast,
             }
 
             IOAddress out_address("0.0.0.0");
-            if (iface->getAddress4(out_address)) {
+            if (!iface->getAddress4(out_address)) {
                 IFACEMGR_ERROR(SocketConfigError, error_handler,
                                "the interface " << iface->getName()
                                << " has no usable IPv4 addresses configured");