From: Mats Klepsland <mats.klepsland@gmail.com>
Date: Fri, 13 May 2016 06:00:19 +0000 (+0200)
Subject: tlsstore: fix memleak
X-Git-Tag: suricata-3.1RC1~152
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45342078e4032deb0916b0f7fb11f1471bf05ee7;p=thirdparty%2Fsuricata.git

tlsstore: fix memleak

Bug #1771.

Direct leak of 1834 byte(s) in 1 object(s) allocated from:
    #0 0x4e2e65 in realloc ??:?
    #1 0xcec27b in LogTlsLogPem /home/mats/suricata/src/log-tlsstore.c:130
    #2 0xcea4f5 in LogTlsStoreLogger /home/mats/suricata/src/log-tlsstore.c:303
    #3 0xd8b99c in OutputPacketLog /home/mats/suricata/src/output-packet.c:104
---

diff --git a/src/log-tlsstore.c b/src/log-tlsstore.c
index a572a627ac..317f80ffc4 100644
--- a/src/log-tlsstore.c
+++ b/src/log-tlsstore.c
@@ -166,6 +166,7 @@ static void LogTlsLogPem(LogTlsStoreLogThread *aft, const Packet *p, SSLState *s
             goto end_fwrite_fp;
     }
     fclose(fp);
+    SCFree(aft->enc_buf);
 
     //Logging certificate informations
     memcpy(filename + (strlen(filename) - 3), "meta", 4);
@@ -222,6 +223,7 @@ static void LogTlsLogPem(LogTlsStoreLogThread *aft, const Packet *p, SSLState *s
 
 end_fwrite_fp:
     fclose(fp);
+    SCFree(aft->enc_buf);
     if (logging_dir_not_writable < LOGGING_WRITE_ISSUE_LIMIT) {
         SCLogWarning(SC_ERR_FWRITE, "Unable to write certificate");
         logging_dir_not_writable++;