From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Tue, 6 Dec 2022 21:58:23 +0000 (+0900)
Subject: hexdecoct: add missing NULL check
X-Git-Tag: v253-rc1~327^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45655e776f3a4deaf68cc21a7716eba5181cbd49;p=thirdparty%2Fsystemd.git

hexdecoct: add missing NULL check

Fixes oss-fuzz#54065 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54065).

Fixes #25650.
---

diff --git a/src/basic/hexdecoct.c b/src/basic/hexdecoct.c
index 0922a49bb17..b9de5bfcdaf 100644
--- a/src/basic/hexdecoct.c
+++ b/src/basic/hexdecoct.c
@@ -606,7 +606,7 @@ ssize_t base64mem_full(
         if (!r)
                 return -ENOMEM;
 
-        for (x = p; x < (const uint8_t*) p + (l / 3) * 3; x += 3) {
+        for (x = p; x && x < (const uint8_t*) p + (l / 3) * 3; x += 3) {
                 /* x[0] == XXXXXXXX; x[1] == YYYYYYYY; x[2] == ZZZZZZZZ */
                 maybe_line_break(&z, r, line_break);
                 *(z++) = base64char(x[0] >> 2);                    /* 00XXXXXX */
diff --git a/test/fuzz/fuzz-resource-record/oss-fuzz-54065 b/test/fuzz/fuzz-resource-record/oss-fuzz-54065
new file mode 100644
index 00000000000..943945213f2
Binary files /dev/null and b/test/fuzz/fuzz-resource-record/oss-fuzz-54065 differ