From: Bo Yang <boyang@samba.org>
Date: Wed, 16 Sep 2009 15:58:35 +0000 (+0800)
Subject: s3: Don't overwrite password in pam_winbind, subsequent pam modules might use the... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=457cbb36700cf460375cdbea85ada5676e03aa45;p=thirdparty%2Fsamba.git

s3: Don't overwrite password in pam_winbind, subsequent pam modules might use the old password and new password.

Signed-off-by: Bo Yang <boyang@samba.org>

Fix bug #6735.
---

diff --git a/source/nsswitch/pam_winbind.c b/source/nsswitch/pam_winbind.c
index 73be3e03f90..4dcfe73533d 100644
--- a/source/nsswitch/pam_winbind.c
+++ b/source/nsswitch/pam_winbind.c
@@ -3056,8 +3056,6 @@ int pam_sm_chauthtok(pam_handle_t * pamh, int flags,
 		ret = winbind_chauthtok_request(ctx, user, pass_old,
 						pass_new, pwdlastset_update);
 		if (ret) {
-			_pam_overwrite(pass_new);
-			_pam_overwrite(pass_old);
 			pass_old = pass_new = NULL;
 			goto out;
 		}
@@ -3086,8 +3084,6 @@ int pam_sm_chauthtok(pam_handle_t * pamh, int flags,
 						   member, cctype, 0,
 						   &error, &info, &policy,
 						   NULL, &username_ret);
-			_pam_overwrite(pass_new);
-			_pam_overwrite(pass_old);
 			pass_old = pass_new = NULL;
 
 			if (ret == PAM_SUCCESS) {