From: Jan Engelhardt <jengelh@inai.de>
Date: Wed, 19 Apr 2023 23:23:28 +0000 (+0200)
Subject: ipv4options: resolve cppcheck warnings
X-Git-Tag: v3.24~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4599c307396b88f5e64e1440a2154298ae39419c;p=thirdparty%2Fxtables-addons.git

ipv4options: resolve cppcheck warnings

libxt_ipv4options.c:123:16: error: Signed integer overflow for expression
'1<<i'. [integerOverflow]
  if (tmp & (1 << i)) {
---

diff --git a/extensions/libxt_ipv4options.c b/extensions/libxt_ipv4options.c
index 696911d..fc31d80 100644
--- a/extensions/libxt_ipv4options.c
+++ b/extensions/libxt_ipv4options.c
@@ -120,14 +120,14 @@ static void ipv4options_print_flags(const struct xt_ipv4options_mtinfo1 *info,
 	unsigned int i;
 
 	for (i = 1; i < 32; ++i)
-		if (tmp & (1 << i)) {
-			if (info->invert & (1 << i))
+		if (tmp & (1U << i)) {
+			if (info->invert & (1U << i))
 				printf("!");
 			if (!numeric && v4opt_names[i] != NULL)
 				printf("%s", v4opt_names[i]);
 			else
 				printf("%u", i);
-			tmp &= ~(1 << i);
+			tmp &= ~(1U << i);
 			if (tmp)
 				printf(",");
 		}