From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 24 Nov 2020 07:04:36 +0000 (+0100)
Subject: qemu: migration: Remove TODO about implementing NBD for TUNNELLED migration
X-Git-Tag: v6.10.0-rc1~32
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45a84971fb857443c2a6dbb89b6dde41dc6912bc;p=thirdparty%2Flibvirt.git

qemu: migration: Remove TODO about implementing NBD for TUNNELLED migration

Our streams are not the best transport for migration data and we support
TLS for security now. It's unlikely that there will be enough motivation
to add a new migration protocol to tunnel NBD too.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index fef0be63a1..85f3c4ccee 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2244,10 +2244,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriverPtr driver,
             }
         }
 
-        /* TODO support NBD for TUNNELLED migration */
-        if (flags & VIR_MIGRATE_TUNNELLED) {
-            VIR_WARN("NBD in tunnelled migration is currently not supported");
-        } else {
+        if (!(flags & VIR_MIGRATE_TUNNELLED)) {
             cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
             priv->nbdPort = 0;
         }